Not logged inOpenClonk Forum
Forum Home Help Search Watchlist Register Login
Up Topic Development / Developer's Corner / Removed more Shareware Restrictions
Post
- - By Carli [de] Date 2010-02-26 11:16 Edited 2010-02-26 18:09
I have a patch that changes the following things:

- no blocking of unregistered using of c4group
- no unregi symbol in network lobby
- no unregistered warning in startup dialog
- no more regjoinonly

I hereby license the following file(s) under the WTFPL license
Attachment: unregis.diff - Patch (2k)
Reply
Parent - - By Carli [de] Date 2010-03-01 09:51
maybe Isilkor could give me write access that I can push the patch?
Reply
Parent - - By Isilkor Date 2010-03-01 13:51
I can't say I'm particularly eager to do this, considering the tantrum you threw on IRC after your patch didn't get pushed immediately. Once someone has found the time to review your patch, it'll get pushed.
Reply
Parent - By Carli [de] Date 2010-03-01 13:52
thx
Reply
Parent - - By Isilkor Date 2010-03-01 20:27
We've looked at your patch, and we think there's some problems still with it:
  • in C4PlayerInfoListBox.cpp, you've removed the changes to the player image, yet keep a deep copy.

  • The facet that was drawn over the player image should be removed, if it's no longer used.

  • You can't set your clonks' death message when you're not registered

  • You're removing checks like if(pRef->isRegJoinOnly()) and if(!Config.Registered()), but the functions themselves stay, leading to dead code.

Furthermore, we believe that the removal doesn't go far enough:
  • The main menu still displays [Not registered], and the game logs the fact that it's unregistered at startup

  • The credits screen still has a "Register now" button

In short, everything that's got to do with the obsolete registration check should go.
Reply
Parent - By Carli [de] Date 2010-03-01 21:13
ok, i will keep on working at it.

I will upload the patch when all things you noticed are fixed
Reply
Parent - - By Carli [de] Date 2010-03-01 21:47

>The facet that was drawn over the player image should be removed, if it's no longer used.


It's part of the GUIIcons2.png file, maybe someone can draw an other pic over it ;)
Reply
Parent - - By Newton [de] Date 2010-03-01 22:21
You could cross it out in paint (or delete the facet) to denote that this space in GUIIcons2 is free for another icon
Reply
Parent - By Carli [de] Date 2010-03-01 22:22
i can only send text patches, should be your work!
Reply
Parent - By Carli [de] Date 2010-03-01 22:21
Here you have ;)
Attachment: unregis.diff (15k)
Reply
Up Topic Development / Developer's Corner / Removed more Shareware Restrictions
Post

Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill