Topic Liquid container branch
This board is threaded (i.e. has a tree structure). Please use the Reply button of the specific post you are referring to, not just any random button. If you want to reply to the topic in general, use the Post button near the top and bottom of the page.
In Response to Marky
Concerning your latest change: Adding the liquid name as a parameter to GetLiquidContainerMaxFillLevel() is not what I intended. If a container has a limit of 300, for example, its capacity for the sum of all liquids is 300. So you could have 300 water in it, or 150 water and 150 oil. Was this what caused the confusion, what you deemed as buggy behaviour? Now you can have, for example, 300 of each type of liquid in a container (which is kind of strange, isn't it?)
Your changes could cause problems with filling barrels - could you please run the Tests.ocf\LiquidContainer.ocs to see if it still works?
Further comments:
* Library_Liquid: You used GetID() a couple of times, you should replace this with GetLiquidType()
* Could you please commit formatted code and actual changes separetely? This makes reviews a lot more easier.
Your changes could cause problems with filling barrels - could you please run the Tests.ocf\LiquidContainer.ocs to see if it still works?
Further comments:
* Library_Liquid: You used GetID() a couple of times, you should replace this with GetLiquidType()
* Could you please commit formatted code and actual changes separetely? This makes reviews a lot more easier.
Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill