Not logged inOpenClonk Forum
Forum Home Help Search Watchlist Register Login
Up Topic Development / Scenario & Object Development / Boomshire Confetti
Post
Poll Confetti?!?
Old Confetti 2 20%
New Confetti 8 80%
Other Confetti? 0 0%
- - By Foaly [de] Date 2019-02-24 07:27 Edited 2019-02-24 07:31
I once made confetti. I think it looks better than the one currently in Boomshire.
So I put it in.

What do you think?
Can we put this in the official version?

I hereby license the file all the files under the CC-BY license

Graphics.png and Particle.txt have to be put in Boomshire.ocs/Confetti.ocd/
Chest.c has to be put in Boomshire.ocs/System.ocg/
Attachment: Particle.txt (47B)
Attachment: Chest.c (2k)
Attachment: Graphics.png (2k)
Reply
Parent - - By Zapper [de] Date 2019-02-27 09:28
Sure, why not!

Do you want to create a pull request on github?
Reply
Parent - - By Foaly [de] Date 2019-02-27 17:29
Do I have to?
Reply
Parent - - By Zapper [de] Date 2019-02-28 11:55
Do you have push access? If so, then that's also possible.

Otherwise, having a pull request allows merging the changes with one click. Otherwise, a patch could also be imported (but is a bit more effort for both sides than a pull request).
Both would keep your name as the author of the changes. If someone else just downloads the files and puts them into the repository, then your name would (usually) not be in the commit as the author
Reply
Parent - - By Foaly [de] Date 2019-02-28 13:22
I don't have push access, but I can try making a pull request on the weekend.
Reply
Parent - - By Zapper [de] Date 2019-02-28 14:09
If that's too much of a hassle, just say so - I don't want to scare you off :)
It's super cool that you want to contribute!

If you are planning to do anything programming related at some point, it's probably a good idea to check out git anyway

Here's a tutorial for pull requests that looks okay: https://www.javahelps.com/2017/04/git-pull-request-complete-guide-for.html
If you are on windows, I can recommend TortoiseGit as a git client.
But GitHub also has a client and you can probably create pull requests from there, too.

Just say if you need some help or if you don't want to have a look at that at all :)

PS: Short steps if you know how to use git:
* Fork repository
* Push changes to your fork
* Click on "create pull request" on your fork
Reply
Parent - - By Foaly [de] Date 2019-02-28 14:54
Thank you, very nice of you, but I already know how to work with git.

If I made changes to the engine, I would definitely give you a diff or a PR, but since it's just a small change I didn't want to set things up...
But if that makes you happy, I can make the PR on the weekend. :P
Reply
Parent - By Sven2 [us] Date 2019-03-01 02:07
If it's a PR, then your name will be in the git history, which is useful to have when we compile the contributor lists on each release.
Reply
Up Topic Development / Scenario & Object Development / Boomshire Confetti
Post

Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill