Some Changes need to build on Linux

Not logged inOpenClonk Forum

Forum Home Help Search Watchlist Register Login

Topic General / Help and Questions / Some Changes need to build on Linux

Post

By deaf_fish [es]

Date 2023-05-24 00:24

Hello,

I have found the following changes were needed to build on Linux:


diff --git a/thirdparty/backward-cpp/backward.hpp b/thirdparty/backward-cpp/backward.hpp
index e2a22bc01..69bd3af70 100644
--- a/thirdparty/backward-cpp/backward.hpp
+++ b/thirdparty/backward-cpp/backward.hpp
@@ -1067,12 +1067,12 @@ private:
        {
                if (result.found) return;
 
-               if ((bfd_get_section_flags(fobj.handle.get(), section)
+               if ((bfd_section_flags(section)
                                        & SEC_ALLOC) == 0)
                        return; // a debug section is never loaded automatically.
 
-               bfd_vma sec_addr = bfd_get_section_vma(fobj.handle.get(), section);
-               bfd_size_type size = bfd_get_section_size(section);
+               bfd_vma sec_addr = bfd_section_vma(section);
+               bfd_size_type size = bfd_section_size(section);
 
                // are we in the boundaries of the section?
                if (addr < sec_addr || addr >= sec_addr + size) {

I figured I would try to put together a PR. My guess is that I need to grab the latest of backward-cpp and not just patch it. Does that sound reasonable to the developers?

By Luchs Date 2023-05-25 13:21

Yeah, probably best to fix that issue upstream in backward-cpp (if it's not fixed there yet) and then upgrading the copy in our repository. I assume a proper patch will be slightly more complicated since it should probably preserve compatibility with older versions of libbfd.

By Anonymous [es]

Date 2023-05-28 00:59

It's in PR https://github.com/openclonk/openclonk/pull/162

Topic General / Help and Questions / Some Changes need to build on Linux

Post