Not logged inOpenClonk Forum
Up Topic Development / Developer's Corner / Bugfixes
- - By Carli [de] Date 2009-05-11 20:18
Here is place to upload bugfixes in the engine:
Parent - - By Carli [de] Date 2009-05-11 20:20
My first bugfix is about the Resolution in Game and GUI.
The bug was, that there were two Resolutions: GUI and Standard-Resolution.
C4Game.cpp line 299
    int32_t iGuiResX = Min<int32_t>(Config.Graphics.GuiResX, Config.Graphics.ResX);
    int32_t iGuiResY = Min<int32_t>(Config.Graphics.GuiResY, Config.Graphics.ResY);


You have to write instead
    int32_t iGuiResX = Config.Graphics.ResX;
    int32_t iGuiResY = Config.Graphics.ResY;
Attachment: C4Game.cpp (131k)
Parent - By Luchs [de] Date 2009-05-11 20:24
Diff!
Parent - - By Sven2 [us] Date 2009-05-15 20:37
That's not a bug. It's an incomplete feature.

The GUI resolution is supposed to be independent of the selected graphics resolution. This should simplify the design of new InGame-GUI, especially scripted GUI, because you can use fixed sizes for all UI elements.

Anyway, it is disabled in the main branch because fonts aren't rendered properly, there are some clipping errors and high resolution GUI graphics do not exist yet. I wonder how you got there. Did you check out the GUIZoom branch?
Parent - By Günther [de] Date 2009-05-15 22:51
We threw away the mercurial test repos and started a new one with the clonk.de svn trunk, because the test repos had some secret stuff in it. I applied your disable-gui-zoom patch to the real openclonk repos some days afterwards.
Reply
Parent - By Carli [de] Date 2009-05-16 12:40
I just wondered why there are two resolutions but there was no window-resizing. So I disabled this "it's not a bug, it's a feature" to play with my wished resolution.
Parent - - By Carli [de] Date 2009-05-11 20:40
Here a second feature:
Add those two lines into C4Game.cpp line 3136:
  KeyboardInput.RegisterKey(new C4CustomKey(C4KeyCodeEx(VK_OEM_PLUS             ), "ZoomIn",         KEYSCOPE_Generic,   new C4KeyCB  <C4GraphicsSystem>(GraphicsSystem, &C4GraphicsSystem::ViewportZoomIn)));
  KeyboardInput.RegisterKey(new C4CustomKey(C4KeyCodeEx(VK_OEM_MINUS            ), "ZoomOut",        KEYSCOPE_Generic,   new C4KeyCB  <C4GraphicsSystem>(GraphicsSystem, &C4GraphicsSystem::ViewportZoomOut)));

These Two lines enable +/- keys for zooming. It makes it easier for noobs to test the zoom feature.
Attachment: C4Game.cpp (131k)
Parent - - By Icewing [de] Date 2009-05-11 20:48
The +/- keys are already used for recording. I think F5 and F6 are easy enough.
Reply
Parent - By Carli [de] Date 2009-05-11 20:51
ack
Parent - - By Newton [es] Date 2009-05-12 14:01
At this point, I think its a good place to mention
WinMerge (Windows) and Kompare (KDE)
for creating diffs/patches.
Parent - By Günther [de] Date 2009-05-12 18:22
"hg export <revision>" and tortoisehg's "export patch" in the context menu of the log are preferable.
Reply
Parent - By bahamada [de] Date 2009-06-04 09:40
in standard/src/CStdFile.cpp row 74

the command open needs 3 parameters. Change to int fd = open(Name, mode, 0777); to fix the compilation error on Linux Systems.
Reply
Up Topic Development / Developer's Corner / Bugfixes

Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill