Not logged inOpenClonk Forum
Up Topic Development / Developer's Corner / 5.2.2 planning
- - By Günther [de] Date 2012-02-01 16:13
So the object definition load problem apparently affects everyone who has () in the path of their data files, because of a piece of code that we inherited complete with "not used yet" comment from Clonk 4. Which apparently translates to "everyone installing 32 bit Clonk on 64 bit windows", if I'm interpreting the "Program Files (x86)" folder name correctly. We've even have a second bug report, so I think this warrants a bug fix release. Are there any other bug fixes that should be included? I'd like to keep the list small though, because I think the 5.1.x series didn't get enough testing for the amount of changes that went in.
Reply
Parent - - By Clonkonaut [ie] Date 2012-02-01 17:30
Would be nice to have the elevator done for a release (texturing is finished by Newton, I guess, but not yet pushed; the case has no nice graphics though).

Also, it would be cool if we seek to replace all the sounds with problematic licenses, so we could say that from the release 5.2.2 on OC is debian ready.
Reply
Parent - By Newton [de] Date 2012-02-01 18:15

> but not yet pushed


shit, you are right! Grr, I pressed that [push] button, I am 100% sure. Oh well, if I am home tonight, I will do it tonight.
Parent - By Clonk-Karl [de] Date 2012-02-01 18:59

> Would be nice to have the elevator done for a release


This is supposed to be a bugfix release so I don't think we should add the elevator to 5.2.2. This is 5.3 stuff. Whether we should do such a release rather soon or not is of course another thing we can and should discuss.
Reply
Parent - - By Clonk-Karl [de] Date 2012-02-01 18:51
Due to a bug in the installer, even the 64 bit binaries got installed into C:\Program Files (x86)\. This is not fixed yet. Another thing that we should do in such a bugfix release is to update the C4Group sort order to the order files in groups are accessed by the engine because currently it takes ages for packed files to be loaded. Also, the autobuild Windows crash should be fixed before we release.

I will try to get all of these done until the weekend.
Reply
Parent - By Clonk-Karl [de] Date 2012-02-01 23:16

> Also, the autobuild Windows crash should be fixed before we release.


Done (hopefully). Some more testing would be good.
Reply
Parent - - By Günther [de] Date 2012-02-02 02:31

> Due to a bug in the installer, even the 64 bit binaries got installed into C:\Program Files (x86)\. This is not fixed yet.


What needs to be done is passing '-DPROGRAMFILES=$PROGRAMFILES64' (verbatim - $PROGRAMFILES64 is a nsis variable, not a shell or cmake or make one). And if we're modifying the installer anyway, testing the new features from http://forum.openclonk.org/topic_show.pl?pid=15017#pid15017 in the same round would probably save work. I think Isilkor solved the second issue mentioned in that post, and I think we can just punt on the first by putting the tiny dll into the repository.
Reply
Parent - By Clonk-Karl [de] Date 2012-02-02 10:12

> What needs to be done is passing '-DPROGRAMFILES=$PROGRAMFILES64'


I tried that already but it didn't work. I did not have a closer look yet, though.
Reply
Parent - By Clonk-Karl [de] Date 2012-02-02 23:20

> Due to a bug in the installer, even the 64 bit binaries got installed into C:\Program Files (x86)\.


This is fixed now as well.
Reply
Parent - - By Clonk-Karl [de] Date 2012-02-04 22:14

> Another thing that we should do in such a bugfix release is to update the C4Group sort order to the order files in groups are accessed by the engine


Done as well. So from my side there are no more showstoppers for a release.
Reply
Parent - By Günther [de] Date 2012-02-11 18:05
I wonder whether the sort order changes are the reason for the CRC problems we had. It's probably not worth it to investigate, but it'd be an explanation.
Reply
- - By Günther [de] Date 2012-02-05 01:15
If nobody beats me to it, I'll pick the patches to the 5.2 branch tomorrow.
Reply
Parent - - By Günther [de] Date 2012-02-05 16:17
There's a release candidate at https://bitbucket.org/guenther/openclonk2/. I've picked a few more commits than those mentioned in the thread so far, hopefully nothing I'll regret. We considered picking the sound changes, but I fear they depend on the sound system changes, and those aren't bugfixes. Though we might want to consider releasing from the default branch instead of picking commits. At least the engine should be in good shape at the moment.
Reply
Parent - By Clonk-Karl [de] Date 2012-02-06 13:38
I would suggest to have a stable 5.2.2 release ~now with the patches you picked and then also a 5.3 release off the default branch quite soon, following the "Release early, Release often" guideline :)
Reply
Parent - - By Newton [de] Date 2012-02-06 14:35
I don't find an overview there of which changes you cherrypicked. Also, do you intend to have the candidate tested? In that case, compiling it for win/linux would be a good idea.
Parent - By B_E [de] Date 2012-02-06 19:49
I assume it's the changes in the branch stable-5.2.
Parent - - By Clonk-Karl [de] Date 2012-02-06 23:20
There are files for testing at http://londeroth.org/~ck. The updates don't seem to work (again). Somebody should fix the mechanism at some point.
Reply
Parent - By Newton [de] Date 2012-02-07 12:54
didnt we gather that the problem lies somewhere in c4group? (and therefore nobody wanted to touch it?)
- - By Günther [de] Date 2012-02-10 21:04 Edited 2012-02-10 21:08
Okay, we're done with the code. We're now somewhat optimistic that the update code will work for the next release, at least on Linux. Debugging that was responsible for most of the delay.
http://blog.openclonk.org/?p=429 has a draft blog post for those with blog accounts. The download page is misbehaving, and we're short on mac builds.

Edit: And ck fixed the download page and we're leaving mac users waiting for now.
Reply
Parent - - By richard [de] Date 2012-02-26 16:35
When will there be a new mac version?
Reply
Parent - - By Mortimer [de] Date 2012-02-26 16:54
There is a build I uploaded recently: http://www.openclonk.org/builds/release/5.2.2/openclonk-5.2.2.dmg
You can try if it actually works ;D
Reply
Parent - - By richard [de] Date 2012-02-26 17:07
I tried it but it did not start. :(
Reply
Parent - - By Mortimer [de] Date 2012-02-26 17:18
:( Hmm.. I guess it's the problem with embedding libraries in the application bundle again.
Reply
Parent - - By richard [de] Date 2012-02-26 17:25
well...I´m sorry. I haven´t got the knowledge to help you, because I can not code. But if you need someone to test, I´ll help you.
Reply
Parent - - By Mortimer [de] Date 2012-04-03 14:59
Hey, new build. Tested under Snow Leopard.
http://www.openclonk.org/builds/release/5.2.2/openclonk-5.2.2.dmg
It's only 64-bit though.
And, yes I'm aware that this post I'm replying to is 37 days old ;c
Reply
Parent - By TLK [au] Date 2012-04-04 02:55
Anyway i ,as a Mac user, am thankful for the build. Runs under Lion as well (10.7.3)
Parent - By richard [de] Date 2012-04-04 05:28
Me, too. Thank you.
Reply
Parent - - By Newton [de] Date 2012-02-27 18:47
I also sent a mail to PeterW (who did the build last time) but he doesn't seem to be available.
Parent - - By richard [de] Date 2012-02-27 19:31
thank you.
Reply
Parent - By PeterW [gb] Date 2012-02-28 11:11
You caught me on vacation. I'll have a look at it over the next days.
Up Topic Development / Developer's Corner / 5.2.2 planning

Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill