I wrote a patch that ignores temp files .* and *.*~ for directory operations and so will enable network games between developers without forcing them to remove all *.*~ files on their own.
I hope, the patch gets committed after reviewing.
I hereby license the following file(s) under the WTFPL license
I hope, the patch gets committed after reviewing.
I hereby license the following file(s) under the WTFPL license
Attachment: ignoretempfiles.patch (3k)
Just one small remark. CC-BY license can not be used for source code (I guess). Use ISC instead
Yeah, no. StdFile is the basic platform-abstraction part, the functions there should be unsurprising. Not working on random files will cause bugs later when somebody uses the functions without being aware of their shortcomings. You'll have to bite the bullet and modify C4Group. If you're lucky, it could be as easy as extending the functionality that ignores directories named "CVS", but I'm not motivated enough to read C4Group right now...
but i think, it would be better to not read them as items of an OS-directory.
when packing, all those files will be ignored anyway, so you won't find them in a c4group
when packing, all those files will be ignored anyway, so you won't find them in a c4group
Well, I gave you my reason for not wanting the platform abstraction functions to do more than one would except them to do. You'll have to give argument against to convince me.
And I can't believe it, but you actually made me look at C4Group. And I'm pretty certain that you'll only have to extend C4Group_TestIgnore. And while you're at it, please make DirContainsScenarios and C4ScenarioListLoader::RegularFolder::DoLoadContents also use that function.
And I can't believe it, but you actually made me look at C4Group. And I'm pretty certain that you'll only have to extend C4Group_TestIgnore. And while you're at it, please make DirContainsScenarios and C4ScenarioListLoader::RegularFolder::DoLoadContents also use that function.
Here you have the (i hope correct) patch.
Attachment: ignoretempfiles.patch (953B)
Yes, that could work. "//no ignored groups" is wrong though - take a look at the contents of C4Group_Ignore. Also, what about my request for C4StartupScenSelDlg.cpp?
License: WTFPL (..what else?)
Attachment: ignoretempfiles.patch (3k)
With "that function", I meant C4Group_TestIgnore. So instead of duplicating the tests, simply call C4Group_TestIgnore in C4StartUpScenSelDlg.cpp. Also, are you sure that SIsModule works with wildcards? And "//no ignored groups" is still wrong: Thumbs.db and *~ are not groups. "//Not in the blacklist" or something similar would be correct.
And the patch appears to be using the ISC license. If you want to use a different one, you should add it to the file, but I urge you to simply use the ISC.
And the patch appears to be using the ISC license. If you want to use a different one, you should add it to the file, but I urge you to simply use the ISC.
You mean this?
(License: ISC)
Edit: tested with Maikel and JCaesar
(License: ISC)
Edit: tested with Maikel and JCaesar
Attachment: ignoretempfiles.patch (4k)
Somebody has to check whether the changes in C4Group.cpp where previously only '.*' was ignored really need to ignore the other patterns, too. Oh, and some minimal testing.
Your latest patch has two additional calls to C4Group_TestIgnore, and it isn't immediately obvious from the patch alone that they're correct. I've now taken the time to check their contexts, and they look good, or at least harmless for everything but the windows c4group commandline utility. So with the entire patch reviewed and tested, I've pushed it.
thx :)
at least i was very inactive - gwX2 needs me. (networkgames etc.)
at least i was very inactive - gwX2 needs me. (networkgames etc.)
Could it be that this patch broke the build (on some systems at least)?
See the latest nightly build log or #253.
See the latest nightly build log or #253.
Powered by mwForum 2.29.7 © 1999-2015 Markus Wichitill